From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 11 Feb 2014 16:08:26 +0000 Subject: [patch] w1: small type cleanup in sysfs Message-Id: <20140211160826.GD9406@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Evgeniy Polyakov , David Fries Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 64 bit systems, a large value for "tmp" could be truncated so we still end up with a ->max_slave_count which is less than one despite the "tmp < 1" check. This is more of a problem for static checkers than a real life issue, but it's simple enough to fix. Signed-off-by: Dan Carpenter diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 9eb816b2ea5e..b96f61b15dc6 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -320,10 +320,10 @@ static ssize_t w1_master_attribute_show_timeout(struct device *dev, struct devic static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - long tmp; + int tmp; struct w1_master *md = dev_to_w1_master(dev); - if (kstrtol(buf, 0, &tmp) = -EINVAL || tmp < 1) + if (kstrtoint(buf, 0, &tmp) = -EINVAL || tmp < 1) return -EINVAL; mutex_lock(&md->mutex);