From: Dan Carpenter <dan.carpenter@oracle.com>
To: Manu Abraham <abraham.manu@gmail.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] stv090x: remove indent levels
Date: Thu, 20 Feb 2014 09:25:59 +0000 [thread overview]
Message-ID: <20140220092559.GX26722@mwanda> (raw)
In-Reply-To: <CAHFNz9K=0TRLDq1q=2+sYknSw6CeGreeEWPSZbfYvsxUNLXJeA@mail.gmail.com>
Guys, what Manu is saying is purest nonsense. The "lock" variable is a
stack variable, it's not a "demodulator Read-modify-Write register".
The implications of changing "if (!lock)" to "if (lock)" are simple and
obvious.
He's not reviewing patches, he's just NAKing them. It's not helpful.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-20 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 9:28 [patch] [media] stv090x: remove indent levels Dan Carpenter
2014-02-18 3:55 ` Manu Abraham
2014-02-18 8:56 ` Dan Carpenter
2014-02-19 5:34 ` Manu Abraham
2014-02-19 7:44 ` Dan Carpenter
2014-02-20 3:39 ` Manu Abraham
2014-02-20 9:25 ` Dan Carpenter [this message]
2014-02-20 12:57 ` Manu Abraham
2014-02-20 10:24 ` Hans Verkuil
2014-02-20 12:35 ` Dan Carpenter
2014-02-21 8:50 ` [patch v2] [media] stv090x: remove indent levels in stv090x_get_coldlock() Dan Carpenter
2014-02-21 11:45 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220092559.GX26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abraham.manu@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).