From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 20 Feb 2014 09:25:59 +0000 Subject: Re: [patch] [media] stv090x: remove indent levels Message-Id: <20140220092559.GX26722@mwanda> List-Id: References: <20140206092800.GB31780@elgon.mountain> <20140218085651.GL26722@mwanda> <20140219074455.GQ26722@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Manu Abraham Cc: Mauro Carvalho Chehab , Hans Verkuil , Alexey Khoroshilov , Linux Media Mailing List , kernel-janitors@vger.kernel.org Guys, what Manu is saying is purest nonsense. The "lock" variable is a stack variable, it's not a "demodulator Read-modify-Write register". The implications of changing "if (!lock)" to "if (lock)" are simple and obvious. He's not reviewing patches, he's just NAKing them. It's not helpful. regards, dan carpenter