From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Jingoo Han <jg1.han@samsung.com>,
Fugang Duan <B38611@freescale.com>,
Benson Leung <bleung@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] Input: remove a duplicative NULL test
Date: Fri, 21 Feb 2014 08:55:06 +0000 [thread overview]
Message-ID: <20140221085506.GB13185@elgon.mountain> (raw)
"pdata" is non-NULL here. We verified that at the start of the
function.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index a70400754e92..40abe90cc924 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -1146,7 +1146,7 @@ static int mxt_probe(struct i2c_client *client,
goto err_free_mem;
}
- data->is_tp = pdata && pdata->is_tp;
+ data->is_tp = pdata->is_tp;
input_dev->name = (data->is_tp) ? "Atmel maXTouch Touchpad" :
"Atmel maXTouch Touchscreen";
next reply other threads:[~2014-02-21 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 8:55 Dan Carpenter [this message]
2014-02-21 9:14 ` [patch] Input: remove a duplicative NULL test fugang.duan
2014-03-13 4:24 ` Benson Leung
2014-03-19 16:02 ` Nick Dyer
2014-02-23 23:23 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221085506.GB13185@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=B38611@freescale.com \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jg1.han@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox