From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Alex Porosanu <alexandru.porosanu@freescale.com>,
Ruchika Gupta <ruchika.gupta@freescale.com>,
Vakul Garg <vakul@freescale.com>,
linux-crypto@vger.kernel.org, Steve Cornelius <sec@pobox.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: caam - writel() arguments are swapped
Date: Tue, 25 Feb 2014 12:18:58 +0000 [thread overview]
Message-ID: <20140225121857.GI12216@gondor.apana.org.au> (raw)
In-Reply-To: <20140224184142.b8d3a2cfb35dfe5f31d332ee@freescale.com>
On Mon, Feb 24, 2014 at 06:41:42PM -0600, Kim Phillips wrote:
> On Fri, 21 Feb 2014 11:51:31 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > My guess is that this little endian configuration is never found in real
> > life,
>
> it is, but the code has not been upstreamed. Steve?
>
> > but if it were then the writel() arguments are in the wrong order
> > so the driver would crash immediately.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
>
> Meanwhile:
>
> Acked-by: Kim Phillips <kim.phillips@freescale.com>
Patch applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2014-02-25 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 8:51 [patch] crypto: caam - writel() arguments are swapped Dan Carpenter
2014-02-25 0:41 ` Kim Phillips
2014-02-25 12:18 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225121857.GI12216@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandru.porosanu@freescale.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=ruchika.gupta@freescale.com \
--cc=sec@pobox.com \
--cc=vakul@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox