From: Ingo Molnar <mingo@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] x86: Add function prototype for setup_default_timer_irq
Date: Mon, 31 Mar 2014 07:21:26 +0000 [thread overview]
Message-ID: <20140331072126.GA1819@gmail.com> (raw)
In-Reply-To: <1395937030-2210-1-git-send-email-luiorpe1@gmail.com>
* Luis Ortega <luiorpe1@gmail.com> wrote:
> This eliminates the following warning in arch/x86/kernel/time.c:
> arch/x86/kernel/time.c:69:13: warning: no previous prototype for ‘setup_default_timer_irq’ [-Wmissing-prototypes]
>
> Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
> ---
> arch/x86/include/asm/time.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/time.h b/arch/x86/include/asm/time.h
> index 92b8aec..935ceb6 100644
> --- a/arch/x86/include/asm/time.h
> +++ b/arch/x86/include/asm/time.h
> @@ -4,6 +4,7 @@
> #include <linux/clocksource.h>
> #include <asm/mc146818rtc.h>
>
> +extern void setup_default_timer_irq(void);
> extern void hpet_time_init(void);
> extern void time_init(void);
Hm, there's already a prototype for that function, in
arch/x86/include/asm/setup.h.
Thanks,
Ingo
prev parent reply other threads:[~2014-03-31 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 15:19 [PATCH] x86: Add function prototype for setup_default_timer_irq Luis Ortega
2014-03-31 7:21 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331072126.GA1819@gmail.com \
--to=mingo@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).