public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] i40e: remove an unneeded check
Date: Thu, 03 Apr 2014 09:13:16 +0000	[thread overview]
Message-ID: <20140403091316.GF6991@mwanda> (raw)
In-Reply-To: <20140328082919.GM25192@mwanda>

On Fri, Mar 28, 2014 at 12:17:16PM -0700, Jeff Kirsher wrote:
> On Fri, 2014-03-28 at 11:29 +0300, Dan Carpenter wrote:
> > We know "ret" is zero here.  No need to check again.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Dan with the latest bunch of patches I just pushed and that Dave
> accepted, the code changes which directly affect your patch to leaves
> your patch only changing the return statement from:
> 
> return ret;
> 
> to 
> 
> return 0;
> 
> but with the recent change in the code, the ret value can be something
> other than 0 so your patch does not appear to be needed any longer.

Sure, yep.  It's not needed anymore.

regards,
dan carpenter


      parent reply	other threads:[~2014-04-03  9:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28  8:29 [patch] i40e: remove an unneeded check Dan Carpenter
2014-03-28 14:13 ` Jeff Kirsher
2014-03-28 19:17 ` Jeff Kirsher
2014-04-03  9:13 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403091316.GF6991@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox