From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Wed, 14 May 2014 20:29:47 +0000 Subject: Re: [patch v2] PM / hibernate: memory corruption in resumedelay_setup() Message-Id: <20140514202947.GA5855@amd.pavel.ucw.cz> List-Id: References: <20140514155602.GA9723@amd.pavel.ucw.cz> <20140514160845.GA5273@mwanda> In-Reply-To: <20140514160845.GA5273@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "Rafael J. Wysocki" , Len Brown , Fabian Frederick , linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed 2014-05-14 19:08:46, Dan Carpenter wrote: > In the original code "resume_delay" is an int so on 64 bits, the call to > kstrtoul() will cause memory corruption. We may as well fix a style > issue here as well and make "resume_delay" unsigned int, since that's > what we pass to ssleep(). > Fixes: 317cf7e5e85e ('PM / hibernate: convert simple_strtoul to kstrtoul') > Signed-off-by: Dan Carpenter Acked-by: Pavel Machek And thanks :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html