From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 28 May 2014 16:42:46 +0000 Subject: [patch 2/2] ALSA: fireworks: small leak on error path Message-Id: <20140528164246.GC1824@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Clemens Ladisch Cc: Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org There was a typo here so we return directly instead of freeing "hwinfo". Signed-off-by: Dan Carpenter diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c index 8e856cc..996fdc4 100644 --- a/sound/firewire/fireworks/fireworks.c +++ b/sound/firewire/fireworks/fireworks.c @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw) /* Hardware metering. */ if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS || hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) { - return -EIO; + err = -EIO; goto end; } efw->phys_in = hwinfo->phys_in;