From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e prohibit deferencing of NULL pointer
Date: Wed, 18 Jun 2014 18:48:14 +0000 [thread overview]
Message-ID: <20140618184814.GO5500@mwanda> (raw)
In-Reply-To: <53A1D769.7090301@ict.tuwien.ac.at>
On Wed, Jun 18, 2014 at 06:16:09PM +0000, Andreas Platschek wrote:
> If ieee = NULL we jump to rx_dropped. Therefore we have to check again,
> if ieee != NULL before we use it.
Take a look at the caller as well. It doesn't check ieee for NULL so
probably this can never be NULL. How would that make sense if ieee were
NULL?
Also the patch doesn't apply. Read Documentation/email-clients.txt
regards,
dan carpenter
prev parent reply other threads:[~2014-06-18 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 18:16 [PATCH] Staging: rtl8192e prohibit deferencing of NULL pointer Andreas Platschek
2014-06-18 18:33 ` Valentina Manea
2014-06-18 18:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618184814.GO5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox