From: Christophe RICARD <christophe.ricard@gmail.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-wireless@vger.kernel.org, linux-nfc@lists.01.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] NFC: st21nfca: Remove double assignment of .owner in struct device_driver
Date: Fri, 25 Jul 2014 09:13:14 +0000 [thread overview]
Message-ID: <20140725111314.0578f122@toffy-MacBookPro> (raw)
In-Reply-To: <1401718860-10901-1-git-send-email-emilgoode@gmail.com>
On Mon, 2 Jun 2014 16:21:00 +0200
Emil Goode <emilgoode@gmail.com> wrote:
> The .owner member of struct device_driver is assigned THIS_MODULE
> twice.
>
> Introduced by:
>
> commit c44cb2edd01ca31471d9385f0895891b006ab904
> ("NFC: dts: st21nfca: Add device-tree (Open Firmware) support to
> st21nfca")
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
> drivers/nfc/st21nfca/i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
> index 3f954ed..95942ca 100644
> --- a/drivers/nfc/st21nfca/i2c.c
> +++ b/drivers/nfc/st21nfca/i2c.c
> @@ -710,7 +710,6 @@ static struct i2c_driver st21nfca_hci_i2c_driver
> = { .driver = {
> .owner = THIS_MODULE,
> .name = ST21NFCA_HCI_I2C_DRIVER_NAME,
> - .owner = THIS_MODULE,
> .of_match_table > of_match_ptr(of_st21nfca_i2c_match), },
> .probe = st21nfca_hci_i2c_probe,
Acked-by: Christophe RICARD <christophe-h.ricard@st.com>
prev parent reply other threads:[~2014-07-25 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:21 [PATCH] NFC: st21nfca: Remove double assignment of .owner in struct device_driver Emil Goode
2014-07-25 9:13 ` Christophe RICARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725111314.0578f122@toffy-MacBookPro \
--to=christophe.ricard@gmail.com \
--cc=aloisio.almeida@openbossa.org \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox