From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: bnx2x: Safe bnx2x_panic_dump()
Date: Mon, 25 Aug 2014 17:10:59 +0000 [thread overview]
Message-ID: <20140825171059.GA22518@mwanda> (raw)
Hello Yuval Mintz,
The patch e261199872a2: "bnx2x: Safe bnx2x_panic_dump()" from Aug 17,
2014, leads to the following static checker warning:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:987 bnx2x_panic_dump()
warn: this array is probably non-NULL. 'fp->txdata_ptr'
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
983
984 /* Tx */
985 for_each_cos_in_tx_queue(fp, cos)
986 {
987 if (!fp->txdata_ptr)
^^^^^^^^^^^^^^
Maybe, "if (fp->txdata_ptr[cos])" was intended?
988 break;
989
990 txdata = *fp->txdata_ptr[cos];
991
992 if (!txdata.tx_cons_sb)
993 continue;
994
regards,
dan carpenter
reply other threads:[~2014-08-25 17:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825171059.GA22518@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox