* re: bnx2x: Safe bnx2x_panic_dump()
@ 2014-08-25 17:10 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-08-25 17:10 UTC (permalink / raw)
To: kernel-janitors
Hello Yuval Mintz,
The patch e261199872a2: "bnx2x: Safe bnx2x_panic_dump()" from Aug 17,
2014, leads to the following static checker warning:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:987 bnx2x_panic_dump()
warn: this array is probably non-NULL. 'fp->txdata_ptr'
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
983
984 /* Tx */
985 for_each_cos_in_tx_queue(fp, cos)
986 {
987 if (!fp->txdata_ptr)
^^^^^^^^^^^^^^
Maybe, "if (fp->txdata_ptr[cos])" was intended?
988 break;
989
990 txdata = *fp->txdata_ptr[cos];
991
992 if (!txdata.tx_cons_sb)
993 continue;
994
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-08-25 17:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-25 17:10 bnx2x: Safe bnx2x_panic_dump() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).