From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: hwrng: xgene - add support for APM X-Gene SoC RNG support
Date: Tue, 09 Sep 2014 10:34:53 +0000 [thread overview]
Message-ID: <20140909103453.GA4507@mwanda> (raw)
Hello Feng Kan,
The patch a91ae4eba9f9: "hwrng: xgene - add support for APM X-Gene
SoC RNG support" from Aug 22, 2014, leads to the following static
checker warning:
drivers/char/hw_random/xgene-rng.c:339 xgene_rng_probe()
warn: unsigned 'ctx->irq' is never less than zero.
drivers/char/hw_random/xgene-rng.c
335 if (IS_ERR(ctx->csr_base))
336 return PTR_ERR(ctx->csr_base);
337
338 ctx->irq = platform_get_irq(pdev, 0);
339 if (ctx->irq < 0) {
^^^^^^^^^^^^
Impossible for unsigned values.
340 dev_err(&pdev->dev, "No IRQ resource\n");
341 return ctx->irq;
342 }
343
344 dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",
regards,
dan carpenter
reply other threads:[~2014-09-09 10:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909103453.GA4507@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox