* re: hwrng: xgene - add support for APM X-Gene SoC RNG support
@ 2014-09-09 10:34 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-09-09 10:34 UTC (permalink / raw)
To: kernel-janitors
Hello Feng Kan,
The patch a91ae4eba9f9: "hwrng: xgene - add support for APM X-Gene
SoC RNG support" from Aug 22, 2014, leads to the following static
checker warning:
drivers/char/hw_random/xgene-rng.c:339 xgene_rng_probe()
warn: unsigned 'ctx->irq' is never less than zero.
drivers/char/hw_random/xgene-rng.c
335 if (IS_ERR(ctx->csr_base))
336 return PTR_ERR(ctx->csr_base);
337
338 ctx->irq = platform_get_irq(pdev, 0);
339 if (ctx->irq < 0) {
^^^^^^^^^^^^
Impossible for unsigned values.
340 dev_err(&pdev->dev, "No IRQ resource\n");
341 return ctx->irq;
342 }
343
344 dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-09-09 10:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-09 10:34 hwrng: xgene - add support for APM X-Gene SoC RNG support Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).