From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] staging: lustre: validate size in ll_setxattr()
Date: Wed, 22 Oct 2014 10:32:41 +0000 [thread overview]
Message-ID: <20141022103241.GG26918@mwanda> (raw)
In-Reply-To: <20141022081233.GB31384@mwanda>
On Wed, Oct 22, 2014 at 02:27:08PM +0400, Andrew Perepechko wrote:
> Hi Dan!
>
> You probably meant putting that check after the followring if-statement,
> since generic extended attributes can have size 1, 2, 3, ...
>
Ok.
> In that case, size = 0 seems to be the wrong value size for an lov param
> as well.
I don't know about this. The code is very clear that size = 0 is
acceptable inside the if statement. Oleg?
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-22 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 8:12 [patch 2/2] staging: lustre: validate size in ll_setxattr() Dan Carpenter
2014-10-22 10:32 ` Dan Carpenter [this message]
2014-10-22 13:53 ` Drokin, Oleg
2014-10-22 14:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022103241.GG26918@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox