* re: ssb: get alp clock from devices with PMU
@ 2014-10-29 9:24 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-10-29 9:24 UTC (permalink / raw)
To: kernel-janitors
Hello Hauke Mehrtens,
The patch f924e1e989b0: "ssb: get alp clock from devices with PMU"
from Dec 5, 2012, leads to the following static checker warning:
drivers/ssb/driver_chipcommon_pmu.c:624 ssb_pmu_get_alp_clock_clk0()
warn: shift is higher precedence than mask
drivers/ssb/driver_chipcommon_pmu.c
619 static u32 ssb_pmu_get_alp_clock_clk0(struct ssb_chipcommon *cc)
620 {
621 u32 crystalfreq;
622 const struct pmu0_plltab_entry *e = NULL;
623
624 crystalfreq = chipco_read32(cc, SSB_CHIPCO_PMU_CTL) &
625 SSB_CHIPCO_PMU_CTL_XTALFREQ >> SSB_CHIPCO_PMU_CTL_XTALFREQ_SHIFT;
This was probably supposed to be:
crystalfreq = (chipco_read32(cc, SSB_CHIPCO_PMU_CTL) &
SSB_CHIPCO_PMU_CTL_XTALFREQ) >> SSB_CHIPCO_PMU_CTL_XTALFREQ_SHIFT;
626 e = pmu0_plltab_find_entry(crystalfreq);
627 BUG_ON(!e);
628 return e->freq * 1000;
629 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-10-29 9:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-29 9:24 ssb: get alp clock from devices with PMU Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).