On Mon, Nov 10, 2014 at 03:27:51PM +0100, Jozsef Kadlecsik wrote: > On Mon, 10 Nov 2014, Pablo Neira Ayuso wrote: > > >From other similar code in that location, I can see Jozsef is using > > this pattern: > > > > if (*len != sizeof(struct ip_set_req_version)) { > > ret = -EINVAL; > > goto done; > > } > > > > I think it would be good to stick to that for consistency. Thanks. > > Absolutely, yes. > > Acked-by: Jozsef Kadlecsik OK, then does this look fine to you? I took over Dan's patch and gave it another spin. See it attached, thanks.