From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Date: Tue, 25 Nov 2014 14:56:01 +0000 Subject: Re: [patch] crypto: sha-mb - remove a bogus NULL check Message-Id: <20141125145601.GC8541@gondor.apana.org.au> List-Id: References: <20141122183628.GD6994@mwanda> In-Reply-To: <20141122183628.GD6994@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "David S. Miller" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Tim Chen , Fengguang Wu , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, Nov 22, 2014 at 09:36:28PM +0300, Dan Carpenter wrote: > This can't be NULL and we dereferenced it earlier. Smatch used to > ignore these things where the pointer was obviously non-NULL but I've > found that sometimes the intention was to check something else so we > were maybe missing bugs. > > Signed-off-by: Dan Carpenter Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt