* [patch] x86_64, traps: always true condition
@ 2014-11-25 16:44 Dan Carpenter
2014-11-25 17:20 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-11-25 16:44 UTC (permalink / raw)
To: kernel-janitors
We should be checking IS_ERR() here. PTR_ERR() is always true.
Fixes: b645af2d5905 ('x86_64, traps: Rework bad_iret')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 67d817e..f176d96 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -331,7 +331,7 @@ dotraplinkage void do_bounds(struct pt_regs *regs, long error_code)
break; /* Success, it was handled */
case 1: /* Bound violation. */
info = mpx_generate_siginfo(regs, xsave_buf);
- if (PTR_ERR(info)) {
+ if (IS_ERR(info)) {
/*
* We failed to decode the MPX instruction. Act as if
* the exception was not caused by MPX.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] x86_64, traps: always true condition
2014-11-25 16:44 [patch] x86_64, traps: always true condition Dan Carpenter
@ 2014-11-25 17:20 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-11-25 17:20 UTC (permalink / raw)
To: kernel-janitors
On Tue, Nov 25, 2014 at 09:12:35AM -0800, Andy Lutomirski wrote:
> On Nov 25, 2014 8:44 AM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
> >
> > We should be checking IS_ERR() here. PTR_ERR() is always true.
> >
> > Fixes: b645af2d5905 ('x86_64, traps: Rework bad_iret')
>
> Huh?
>
> I agree with the change, but the Fixes line looks wrong.
>
Oops. Sorry for that, it was the fe3d197f8431 ('x86, mpx: On-demand
kernel allocation of bounds tables') change. I will resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-25 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-25 16:44 [patch] x86_64, traps: always true condition Dan Carpenter
2014-11-25 17:20 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).