From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 06 Jan 2015 10:04:34 +0000 Subject: Re: [V9fs-developer] [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_ Message-Id: <20150106100434.GH15033@mwanda> List-Id: References: <5317A59D.4@users.sourceforge.net> <54A01326.3050306@users.sourceforge.net> <54A06AB9.4020505@users.sourceforge.net> <20150105112206.GC15033@mwanda> <54AB02F3.5020308@users.sourceforge.net> <54AB0844.5090405@users.sourceforge.net> <20150106081253.GA22484@u-galfione> <20150106092719.GB22484@u-galfione> In-Reply-To: <20150106092719.GB22484@u-galfione> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dominique Martinet Cc: Julia Lawall , SF Markus Elfring , Latchesar Ionkov , Eric Van Hensbergen , kernel-janitors@vger.kernel.org, LKML , Ron Minnich , v9fs-developer@lists.sourceforge.net On Tue, Jan 06, 2015 at 10:27:19AM +0100, Dominique Martinet wrote: > (All other patches in the set look good to me at second glance, now. > To answer Dan's mail, none of these are bug fix as far as I've seen, > just avoiding unnecessary checks for null or calls+check/warn depending > on whether you apply patch #1 first) You're right. The patch set introduces bugs then fixes them later. regards, dan carpenter