From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sat, 17 Jan 2015 23:54:58 +0000 Subject: Re: lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)->iov_base, which is __user Message-Id: <20150117235458.GA23280@kroah.com> List-Id: References: <20150107083654.GK15033@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrey Utkin Cc: "Dilger, Andreas" , OSUOSL Drivers , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Drokin, Oleg" , "HPDD-discuss@ml01.01.org" , Dan Carpenter On Wed, Jan 07, 2015 at 02:28:12PM +0200, Andrey Utkin wrote: > 2015-01-07 13:32 GMT+02:00 Dilger, Andreas : > > On 2015/01/07, 1:36 AM, "Dan Carpenter" wrote: > >> Didn't Al change these to kvec instead of iovec? You have to look at > >> the callers to figure out if it's actually a user space pointer or a > >> kernel pointer. > > > > A patch was sent by Al on Dec 2 to replace iovec with kvec, in a thread > > titled "[PATCH] staging:lustre:lnet: Incorrect type in assignment". Greg > > replied on Dec 10 in another thread (also fixing this same warning) titled > > "[PATCH] staging: lustre: Fix the warning messages about casting without > > __user macro" that Al's patch was in the staging tree for 3.19-rc1. > > In current linux-next, I see none of the mentioned patches. Also I > don't see them mentioned in GKH's merge commit "Merge tag > 'staging-3.19-rc1'..." > Is it ok? Al's patch is now merged.