Re: [PATCH] MTD: Deletion of checks before the function call "iounmap"

Brian Norris
2015-01-19T18:30:57Z

On Mon, Jan 19, 2015 at 07:19:34PM +0100, SF Markus Elfring wrote:
> > Anyway, I'm essentially saying that I'd like to be 100% sure we have a
> > guarantee before dropping all these.
>
> You can not be absolutely sure. There are various implementation details
> which will eventually need further considerations.

Let's consider them first. We don't ship code that is missing the
implementation details. (At least, we try not to!)

> I hope that a reasonable confidence can be achieved here.
>
>
> >> This issue was detected by using the Coccinelle software.
> >
> > What script?
>
> I published scripts for static source code analysis in March 2004.

I didn't ask "when?"; where?

> > Hand-rolled I guess?
>
> An extended version found some update candidates in source files for Linux
> according to the software development status of "next-20141226".
>
> My approach is still incomplete at the moment.

Then please complete it.

Thanks,
Brian