Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

SF Markus Elfring
2014-11-21T12:21:36Z

> ring_free does not check for null:
> http://lxr.free-electrons.com/source/drivers/thunderbolt/nhi.c#L398
>
> Maybe your software confuses the method with:
> http://lxr.free-electrons.com/source/drivers/char/tpm/xen-tpmfront.c#L268

Thanks for your feedback.

I am sorry for a bit of confusion here.

1. Would it make sense that a variant for the thunderbolt ring_free()
function will also perform input parameter validation?

2. Are any additional prefixes appropriate so that further name space
conflicts can be better avoided?

Regards,
Markus