Re: [PATCH] block-skd: Deletion of an unnecessary check before the function call "kfree"

SF Markus Elfring
2015-06-28T11:34:15Z

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 Dec 2014 18:15:46 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/block/skd_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index 1e46eb2..c4b0259 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev)
> return 0;
>
> msix_out:
> - if (entries)
> - kfree(entries);
> + kfree(entries);
> skd_release_msix(skdev);
> return rc;
> }
>

Would anybody like to integrate this update suggestion
into another source code repository?

Regards,
Markus