[patch] drm/bridge: checking the wrong variable

[patch] drm/bridge: checking the wrong variable

[Dan Carpenter]

We were supposed to check "fmts" here instead of "formats".  I suppose
it eventually leads to a NULL dereference.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 98fb640..8ae239f 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -783,7 +783,7 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info,
 	if (formats && num_formats) {
 		fmts = kmemdup(formats, sizeof(*formats) * num_formats,
 			       GFP_KERNEL);
-		if (!formats)
+		if (!fmts)
 			return -ENOMEM;
 	}
 

Re: [patch] drm/bridge: checking the wrong variable

[Daniel Kurtz]

Hi Dan,

nit: this patch is not really for "drm/bridge".

On Wed, Jan 28, 2015 at 2:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We were supposed to check "fmts" here instead of "formats".  I suppose
> it eventually leads to a NULL dereference.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>

Otherwise, good catch!

Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 98fb640..8ae239f 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -783,7 +783,7 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info,
>         if (formats && num_formats) {
>                 fmts = kmemdup(formats, sizeof(*formats) * num_formats,
>                                GFP_KERNEL);
> -               if (!formats)
> +               if (!fmts)
>                         return -ENOMEM;
>         }
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [patch] drm/bridge: checking the wrong variable

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

On Wed, Jan 28, 2015 at 02:46:46PM +0800, Daniel Kurtz wrote:
> Hi Dan,
> 
> nit: this patch is not really for "drm/bridge".
> 
> On Wed, Jan 28, 2015 at 2:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > We were supposed to check "fmts" here instead of "formats".  I suppose
> > it eventually leads to a NULL dereference.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> 
> Otherwise, good catch!
> 
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

I've reworded the commit message slightly and applied this. Thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]