From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: csiostor:T5 Firmware fix and cleanup.
Date: Thu, 29 Jan 2015 17:14:48 +0000 [thread overview]
Message-ID: <20150129171448.GA30639@mwanda> (raw)
Hello Praveen Madhavan,
The patch 216ce69c7ff5: "csiostor:T5 Firmware fix and cleanup." from
Jan 27, 2015, leads to the following static checker warning:
drivers/scsi/csiostor/csio_hw.c:1780 csio_hw_use_fwconfig()
warn: missing error code here? 'csio_hw_validate_caps()' failed.
drivers/scsi/csiostor/csio_hw.c
1776 }
1777
1778 /* Validate device capabilities */
1779 if (csio_hw_validate_caps(hw, mbp))
We should probably preserve the error code here instead of returning
success.
1780 goto bye;
1781 /*
regards,
dan carpenter
reply other threads:[~2015-01-29 17:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129171448.GA30639@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox