From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: Remove state argument from skb_find_text()
Date: Wed, 18 Feb 2015 09:50:06 +0000 [thread overview]
Message-ID: <20150218095006.GA5206@mwanda> (raw)
In-Reply-To: <1424184592-2441-1-git-send-email-prtvar.b@gmail.com>
On Tue, Feb 17, 2015 at 03:49:52PM +0100, Bojan Prtvar wrote:
> No need to pass textsearch state as argument to skb_find_text().
> Instead, it can be local variable.
>
> Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
> ---
> This patch changes internal kernel API. I am sending it here first in hope to get some friendly review.
Hm... That's odd.
This was added in commit 3fc7e8a6d842f ('[NET]: skb_find_text() -
Find a text pattern in skb data') and it's pretty clear that we're
deliberately passing an uninitialized struct. Make sure that you CC
Thomas Graf <tgraf@suug.ch> on your email.
The only thing I can think of is that originally, we didn't do it your
way because we thought this would be called recursively and didn't want
to run out of stack space. But it never has been called recursively so
your patch seems ok.
I hope you have tested this patch. :)
Anyway, it seems like it should work to me. I say forward it to netdev.
The worst that can happen is that you learn something. :)
Maybe flesh out the commit message a bit.
regards,
dan carpenter
prev parent reply other threads:[~2015-02-18 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 14:49 [PATCH] net: Remove state argument from skb_find_text() Bojan Prtvar
2015-02-18 9:50 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218095006.GA5206@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).