* [patch] tcm_fc: missing curly braces in ft_invl_hw_context()
@ 2015-02-25 13:21 Dan Carpenter
2015-02-27 11:52 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-02-25 13:21 UTC (permalink / raw)
To: Nicholas A. Bellinger, Kiran Patil
Cc: Vasu Dev, linux-scsi, target-devel, kernel-janitors
From the indenting, it looks like curly braces were intended here.
Fixes: dcd998ccdbf7 ('tcm_fc: Handle DDP/SW fc_frame_payload_get failures in ft_recv_write_data')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
index 97b486c..583e755 100644
--- a/drivers/target/tcm_fc/tfc_io.c
+++ b/drivers/target/tcm_fc/tfc_io.c
@@ -359,7 +359,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
ep = fc_seq_exch(seq);
if (ep) {
lport = ep->lp;
- if (lport && (ep->xid <= lport->lro_xid))
+ if (lport && (ep->xid <= lport->lro_xid)) {
/*
* "ddp_done" trigger invalidation of HW
* specific DDP context
@@ -374,6 +374,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
* identified using ep->xid)
*/
cmd->was_ddp_setup = 0;
+ }
}
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] tcm_fc: missing curly braces in ft_invl_hw_context()
2015-02-25 13:21 [patch] tcm_fc: missing curly braces in ft_invl_hw_context() Dan Carpenter
@ 2015-02-27 11:52 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2015-02-27 11:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kiran Patil, Vasu Dev, linux-scsi, target-devel, kernel-janitors
On Wed, 2015-02-25 at 16:21 +0300, Dan Carpenter wrote:
> From the indenting, it looks like curly braces were intended here.
>
> Fixes: dcd998ccdbf7 ('tcm_fc: Handle DDP/SW fc_frame_payload_get failures in ft_recv_write_data')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
> index 97b486c..583e755 100644
> --- a/drivers/target/tcm_fc/tfc_io.c
> +++ b/drivers/target/tcm_fc/tfc_io.c
> @@ -359,7 +359,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
> ep = fc_seq_exch(seq);
> if (ep) {
> lport = ep->lp;
> - if (lport && (ep->xid <= lport->lro_xid))
> + if (lport && (ep->xid <= lport->lro_xid)) {
> /*
> * "ddp_done" trigger invalidation of HW
> * specific DDP context
> @@ -374,6 +374,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
> * identified using ep->xid)
> */
> cmd->was_ddp_setup = 0;
> + }
> }
> }
> }
Thanks Dan. Applied to target-pending/master.
--nab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-27 11:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 13:21 [patch] tcm_fc: missing curly braces in ft_invl_hw_context() Dan Carpenter
2015-02-27 11:52 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).