From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: net: bcmgenet: add main driver file
Date: Wed, 25 Feb 2015 13:34:22 +0000 [thread overview]
Message-ID: <20150225133422.GT19745@mwanda> (raw)
Hello Florian Fainelli,
The patch 1c1008c793fa: "net: bcmgenet: add main driver file" from
Feb 13, 2014, leads to the following static checker warning:
drivers/net/ethernet/broadcom/genet/bcmgenet.c:1955 bcmgenet_init_dma()
error: potential null dereference 'priv->tx_cbs'. (kcalloc returns null)
drivers/net/ethernet/broadcom/genet/bcmgenet.c
1952 priv->tx_cbs = kcalloc(priv->num_tx_bds, sizeof(struct enet_cb),
1953 GFP_KERNEL);
1954 if (!priv->tx_cbs) {
1955 bcmgenet_fini_dma(priv);
^^^^^^^^^^^^^^^^^^^^^^^
We dereference "priv->tx_cbs" inside the bcmgenet_fini_dma() function.
1956 return -ENOMEM;
1957 }
regards,
dan carpenter
reply other threads:[~2015-02-25 13:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225133422.GT19745@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox