* [patch -next] drm/i915: fix a printk format
@ 2015-02-26 16:53 Dan Carpenter
2015-02-26 19:21 ` [Intel-gfx] " Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-02-26 16:53 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx, kernel-janitors, dri-devel
This printk leads to the following Smatch warning:
drivers/gpu/drm/i915/i915_gem_gtt.c:336 alloc_pt_range()
error: '%pa' expects argument of type 'phys_addr_t*',
argument 5 has type 'struct i915_page_table_entry*'
It looks like a simple typo to me where "%p" was intended instead of
"%pa".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index e05488e..48eff65 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -334,7 +334,7 @@ static int alloc_pt_range(struct i915_page_directory_entry *pd, uint16_t pde, si
goto err_out;
}
WARN(pd->page_table[i],
- "Leaking page directory entry %d (%pa)\n",
+ "Leaking page directory entry %d (%p)\n",
i, pd->page_table[i]);
pd->page_table[i] = pt;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Intel-gfx] [patch -next] drm/i915: fix a printk format
2015-02-26 16:53 [patch -next] drm/i915: fix a printk format Dan Carpenter
@ 2015-02-26 19:21 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2015-02-26 19:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Daniel Vetter, intel-gfx, kernel-janitors,
dri-devel
On Thu, Feb 26, 2015 at 07:53:54PM +0300, Dan Carpenter wrote:
> This printk leads to the following Smatch warning:
>
> drivers/gpu/drm/i915/i915_gem_gtt.c:336 alloc_pt_range()
> error: '%pa' expects argument of type 'phys_addr_t*',
> argument 5 has type 'struct i915_page_table_entry*'
>
> It looks like a simple typo to me where "%p" was intended instead of
> "%pa".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued for -next, thanks for the patch.
-Daniel
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index e05488e..48eff65 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -334,7 +334,7 @@ static int alloc_pt_range(struct i915_page_directory_entry *pd, uint16_t pde, si
> goto err_out;
> }
> WARN(pd->page_table[i],
> - "Leaking page directory entry %d (%pa)\n",
> + "Leaking page directory entry %d (%p)\n",
> i, pd->page_table[i]);
> pd->page_table[i] = pt;
> }
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-26 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-26 16:53 [patch -next] drm/i915: fix a printk format Dan Carpenter
2015-02-26 19:21 ` [Intel-gfx] " Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).