From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: kdbus: add connection, queue handling and message validation code
Date: Tue, 17 Mar 2015 18:29:32 +0000 [thread overview]
Message-ID: <20150317182932.GB30354@mwanda> (raw)
Hello Daniel Mack,
The patch 5fc8dd5c84fc: "kdbus: add connection, queue handling and
message validation code" from Sep 11, 2014, leads to the following
static checker warning:
ipc/kdbus/connection.c:2000 kdbus_cmd_send()
warn: 'cancel_fd' isn't an ERR_PTR
ipc/kdbus/connection.c
1998 if (argv[1].item) {
1999 cancel_fd = fget(argv[1].item->fds[0]);
^^^^
fget() returns NULL on error.
2000 if (IS_ERR(cancel_fd)) {
2001 ret = PTR_ERR(cancel_fd);
2002 cancel_fd = NULL;
2003 goto exit;
2004 }
2005
2006 if (!cancel_fd->f_op->poll) {
2007 ret = -EINVAL;
2008 goto exit;
2009 }
2010 }
regards,
dan carpenter
next reply other threads:[~2015-03-17 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 18:29 Dan Carpenter [this message]
2015-03-17 18:49 ` kdbus: add connection, queue handling and message validation code Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317182932.GB30354@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).