From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: vxlan: Move socket initialization to within rtnl scope
Date: Mon, 23 Mar 2015 15:56:12 +0000 [thread overview]
Message-ID: <20150323155612.GD24038@mwanda> (raw)
Hello Marcelo Ricardo Leitner,
This is a semi-automatic email about new static checker warnings.
The patch 56ef9c909b40: "vxlan: Move socket initialization to within
rtnl scope" from Mar 18, 2015, leads to the following Smatch
complaint:
drivers/net/vxlan.c:2267 vxlan_stop()
error: we previously assumed 'vs' could be null (see line 2257)
drivers/net/vxlan.c
2256
2257 if (vs && vxlan_addr_multicast(&vxlan->default_dst.remote_ip) &&
^^
Existing code assumed "vs" could be NULL.
2258 !vxlan_group_used(vn, vxlan)) {
2259 ret = vxlan_igmp_leave(vxlan);
2260 if (ret)
2261 return ret;
2262 }
2263
2264 del_timer_sync(&vxlan->age_timer);
2265
2266 vxlan_flush(vxlan);
2267 vxlan_sock_release(vs);
^^
Patch adds new unchecked dereference.
2268
2269 return ret;
regards,
dan carpenter
next reply other threads:[~2015-03-23 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 15:56 Dan Carpenter [this message]
2015-03-23 19:23 ` [PATCH net-next] vxlan: simplify if clause in dev_close Marcelo Ricardo Leitner
2015-03-23 21:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323155612.GD24038@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).