* [patch 1/2] tpm, tpm_tis: potential underflow bug in tpm_tis_recv()
@ 2015-03-24 9:19 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-03-24 9:19 UTC (permalink / raw)
To: kernel-janitors
If "expected" is less than TPM_HEADER_SIZE (10) then it could mean we
try to read a negative number of bytes.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index f2dffa7..aa96ecd 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -258,7 +258,7 @@ static int tpm_tis_recv(struct tpm_chip *chip, u8 *buf, size_t count)
}
expected = be32_to_cpu(*(__be32 *) (buf + 2));
- if (expected > count) {
+ if (expected < TPM_HEADER_SIZE || expected > count) {
size = -EIO;
goto out;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-24 9:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-24 9:19 [patch 1/2] tpm, tpm_tis: potential underflow bug in tpm_tis_recv() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).