From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 01/16] Clean up unnecessary void* pointer cast.
Date: Wed, 22 Apr 2015 16:51:32 +0000 [thread overview]
Message-ID: <20150422165132.GS16501@mwanda> (raw)
In-Reply-To: <1429720530-20044-1-git-send-email-firogm@gmail.com>
The subject need to be written by hand and they need to be unique.
git log --oneline driver/file.c
Copy and paste the patch prefix for each email you send.
On Thu, Apr 23, 2015 at 12:35:15AM +0800, Firo Yang wrote:
> Signed-off-by: Firo Yang <firogm@gmail.com>
> ---
> sound/pci/emu10k1/emufx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
> index 56fc47b..8a39a6f 100644
> --- a/sound/pci/emu10k1/emufx.c
> +++ b/sound/pci/emu10k1/emufx.c
> @@ -1186,8 +1186,8 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu)
> if (!icode)
> return err;
>
> - icode->gpr_map = (u_int32_t __user *) kcalloc(512 + 256 + 256 + 2 * 1024,
> - sizeof(u_int32_t), GFP_KERNEL);
This cast is special. It's a Sparse thing. Since I know you have
Smatch installed you can do
~/path/to/smatch/smatch_scripts/kchecker --sparse sound/pci/emu10k1/emufx.c
I'm not positive if you need a __force in there?
Anyway, don't remove this.
regards,
dan carpenter
prev parent reply other threads:[~2015-04-22 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 16:35 [PATCH 01/16] Clean up unnecessary void* pointer cast Firo Yang
2015-04-22 16:51 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422165132.GS16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox