From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: mfd: Support 88pm80x in 80x driver
Date: Fri, 15 May 2015 08:23:02 +0000 [thread overview]
Message-ID: <20150515082302.GA14154@mwanda> (raw)
In-Reply-To: <20150514103124.GA21248@mwanda>
On Fri, May 15, 2015 at 09:06:55AM +0800, Qiao Zhou wrote:
> >>@@ -360,8 +366,14 @@ static inline int pm80x_dev_resume(struct device *dev)
> >> struct pm80x_chip *chip = dev_get_drvdata(pdev->dev.parent);
> >> int irq = platform_get_irq(pdev, 0);
> >>
> >>+ if ((irq < 0) || (irq >= 24)) {
> >>+ dev_err(dev, "pm80x: wrong irq 0x%x\n", irq);
> >>+
> >
> >Superfluous '\n'.
> Will refine it.
The \n is ok isn't it?
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-15 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 10:31 mfd: Support 88pm80x in 80x driver Dan Carpenter
2015-05-14 11:35 ` Qiao Zhou
2015-05-14 12:50 ` Lee Jones
2015-05-15 1:06 ` Qiao Zhou
2015-05-15 8:23 ` Dan Carpenter [this message]
2015-05-18 9:23 ` Lee Jones
2015-05-18 9:27 ` Lee Jones
2015-06-05 2:17 ` zhouqiao
2015-06-05 7:27 ` Lee Jones
2015-06-05 7:49 ` zhouqiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515082302.GA14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox