From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Breaking lines in function headers
Date: Tue, 19 May 2015 15:20:19 +0000 [thread overview]
Message-ID: <20150519152018.GC4150@mwanda> (raw)
In-Reply-To: <555B3901.3090707@wimdewith.com>
On Tue, May 19, 2015 at 05:14:49PM +0200, Wim de With wrote:
> On 19-5-2015 16:08, Dan Carpenter wrote:
> > First of gmail always marks your emails as spam so I only see the
> > replies.
>
> That might be because of my SPF/DMARC configuration. I think it's fixed now.
>
> > Both declaration formats are acceptable.
> >
> > These days instead of "substantially to the right" most people
> > insist that they be aligned. I think checkpatch.pl --strict enforces
> > this.
>
> So as long as I use the same style consistently in a source file, I'm good?
>
I'm slightly confused what you mean. If you're asking if you should
redo the visorchipset.c patch then don't bother with that. The original
code is fine.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-19 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 13:22 Breaking lines in function headers Wim de With
2015-05-19 13:38 ` Julia Lawall
2015-05-19 14:08 ` Dan Carpenter
2015-05-19 15:14 ` Wim de With
2015-05-19 15:20 ` Dan Carpenter [this message]
2015-05-19 15:26 ` Wim de With
2015-05-19 15:39 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519152018.GC4150@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox