From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@kernel.org>
Date: Wed, 20 May 2015 08:17:34 +0000
Subject: Re: [patch] watchdog: double lock typo in watchdog_nmi_enable_all()
Message-Id: <20150520081734.GA25966@gmail.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20150520074408.GC18278@mwanda>
In-Reply-To: <20150520074408.GC18278@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org


* Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The mutex_lock() should obviously be mutex_unlock().
> 
> Fixes: ab992dc38f9a ('watchdog: Fix merge 'conflict'')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This bug is already in mainline.
> 
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index c57e67d..a6ffa43 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -628,7 +628,7 @@ void watchdog_nmi_enable_all(void)
>  	put_online_cpus();
>  
>  unlock:
> -	mutex_lock(&watchdog_proc_mutex);
> +	mutex_unlock(&watchdog_proc_mutex);
>  }
>  
>  void watchdog_nmi_disable_all(void)

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo