* [patch] iio: light: signedness bug in stk3310_write_raw()
@ 2015-05-27 8:24 Dan Carpenter
2015-05-27 9:10 ` Breana, Tiberiu A
2015-05-27 9:31 ` Daniel Baluta
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-05-27 8:24 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Tiberiu Breana, linux-iio, kernel-janitors
"index" needs to be signed for the error handling to work.
Fixes: be9e6229d676 ('iio: light: Add support for Sensortek STK3310')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
index e79b9d8..fee4297 100644
--- a/drivers/iio/light/stk3310.c
+++ b/drivers/iio/light/stk3310.c
@@ -370,7 +370,7 @@ static int stk3310_write_raw(struct iio_dev *indio_dev,
int val, int val2, long mask)
{
int ret;
- unsigned int index;
+ int index;
struct stk3310_data *data = iio_priv(indio_dev);
switch (mask) {
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [patch] iio: light: signedness bug in stk3310_write_raw()
2015-05-27 8:24 [patch] iio: light: signedness bug in stk3310_write_raw() Dan Carpenter
@ 2015-05-27 9:10 ` Breana, Tiberiu A
2015-05-27 9:31 ` Daniel Baluta
1 sibling, 0 replies; 4+ messages in thread
From: Breana, Tiberiu A @ 2015-05-27 9:10 UTC (permalink / raw)
To: Dan Carpenter, Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Wednesday, May 27, 2015 11:24 AM
> To: Jonathan Cameron
> Cc: Hartmut Knaack; Lars-Peter Clausen; Peter Meerwald; Breana, Tiberiu A;
> linux-iio@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] iio: light: signedness bug in stk3310_write_raw()
>
> "index" needs to be signed for the error handling to work.
>
Thanks for this. I don't know how it slipped by our reviews.
Reviewed-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
> Fixes: be9e6229d676 ('iio: light: Add support for Sensortek STK3310')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index
> e79b9d8..fee4297 100644
> --- a/drivers/iio/light/stk3310.c
> +++ b/drivers/iio/light/stk3310.c
> @@ -370,7 +370,7 @@ static int stk3310_write_raw(struct iio_dev
> *indio_dev,
> int val, int val2, long mask)
> {
> int ret;
> - unsigned int index;
> + int index;
> struct stk3310_data *data = iio_priv(indio_dev);
>
> switch (mask) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] iio: light: signedness bug in stk3310_write_raw()
2015-05-27 8:24 [patch] iio: light: signedness bug in stk3310_write_raw() Dan Carpenter
2015-05-27 9:10 ` Breana, Tiberiu A
@ 2015-05-27 9:31 ` Daniel Baluta
2015-05-27 9:35 ` Dan Carpenter
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Baluta @ 2015-05-27 9:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Tiberiu Breana, linux-iio@vger.kernel.org,
kernel-janitors
On Wed, May 27, 2015 at 11:24 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> "index" needs to be signed for the error handling to work.
>
> Fixes: be9e6229d676 ('iio: light: Add support for Sensortek STK3310')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Hi Dan,
Did you find this with a tool?
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] iio: light: signedness bug in stk3310_write_raw()
2015-05-27 9:31 ` Daniel Baluta
@ 2015-05-27 9:35 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-05-27 9:35 UTC (permalink / raw)
To: Daniel Baluta
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Tiberiu Breana, linux-iio@vger.kernel.org,
kernel-janitors
On Wed, May 27, 2015 at 12:31:26PM +0300, Daniel Baluta wrote:
> On Wed, May 27, 2015 at 11:24 AM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
> > "index" needs to be signed for the error handling to work.
> >
> > Fixes: be9e6229d676 ('iio: light: Add support for Sensortek STK3310')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Hi Dan,
>
> Did you find this with a tool?
Yeah. This is a Smatch thing.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-27 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 8:24 [patch] iio: light: signedness bug in stk3310_write_raw() Dan Carpenter
2015-05-27 9:10 ` Breana, Tiberiu A
2015-05-27 9:31 ` Daniel Baluta
2015-05-27 9:35 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).