[PATCH 02/12] staging: lustre: fld: Use !x to check for kzalloc failure

Julia Lawall
2015-06-20T16:59:00Z

!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
statement S1, S2;
@@

x = kzalloc(...);
if (
- x = NULL
+ !x
) S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +-
drivers/staging/lustre/lustre/fld/fld_request.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff -u -p a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
--- a/drivers/staging/lustre/lustre/fld/fld_request.c
+++ b/drivers/staging/lustre/lustre/fld/fld_request.c
@@ -222,7 +222,7 @@ int fld_client_add_target(struct lu_clie
fld->lcf_name, name, tar->ft_idx);

target = kzalloc(sizeof(*target), GFP_NOFS);
- if (target = NULL)
+ if (!target)
return -ENOMEM;

spin_lock(&fld->lcf_lock);
diff -u -p a/drivers/staging/lustre/lustre/fld/fld_cache.c b/drivers/staging/lustre/lustre/fld/fld_cache.c
--- a/drivers/staging/lustre/lustre/fld/fld_cache.c
+++ b/drivers/staging/lustre/lustre/fld/fld_cache.c
@@ -70,7 +70,7 @@ struct fld_cache *fld_cache_init(const c
LASSERT(cache_threshold < cache_size);

cache = kzalloc(sizeof(*cache), GFP_NOFS);
- if (cache = NULL)
+ if (!cache)
return ERR_PTR(-ENOMEM);

INIT_LIST_HEAD(&cache->fci_entries_head);