From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 25 Jun 2015 09:55:00 +0000 Subject: Re: [PATCH] SCSI-wd33c93: Deletion of a check before the function call "wd33c93_setup" Message-Id: <20150625095500.GZ28762@mwanda> List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558ACDDE.5090403@users.sourceforge.net> In-Reply-To: <558ACDDE.5090403@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: "James E. J. Bottomley" , linux-scsi@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Wed, Jun 24, 2015 at 05:33:50PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Jun 2015 17:15:17 +0200 > > The wd33c93_setup() function performs also input parameter validation. > Thus the test around the call is not needed. > Guys, you should be aware that Markus auto generates his patches and he doesn't even do a cursory review. "I find it acceptable that some of my update suggestions do not fit to your quality expectations at the moment." -- Markus Elfring (https://lkml.org/lkml/2015/1/22/446) regards, dan carpenter