* [GIT PULL 0/7] perf/core improvements
@ 2015-06-25 21:10 Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 2/7] perf header: Delete an unnecessary check before the calling free_event_desc() Arnaldo Carvalho de Melo
2015-06-26 8:39 ` [GIT PULL 0/7] perf/core improvements Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-06-25 21:10 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Andi Kleen,
David Ahern, Jiri Olsa, Julia Lawall, kernel-janitors,
Markus Elfring, Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 27451700dfa01a05cdb4d9d74501536165158034:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-06-25 09:28:42 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to a22e99cd74a31dee4b5241bd60a256c629c808da:
perf tools: Make perf_evsel__(nr_)cpus generic (2015-06-25 17:15:39 -0300)
----------------------------------------------------------------
perf/core improvements and refactorings:
Infrastructure:
- Reference count the cpu_map and thread_map classes. (Jiri Olsa)
- Set evsel->{cpus,threads} from the evlist, if not set,
allowing the generalization of some 'perf stat' functions that
previously were accessing private static evlist variable. (Jiri Olsa)
- Delete an unnecessary check before the calling
free_event_desc() (Markus Elfring)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf tools: Future-proof thread_map allocation size calculation
Jiri Olsa (5):
perf tools: Add reference counting for cpu_map object
perf tools: Add reference counting for thread_map object
perf evlist: Propagate cpu maps to evsels in an evlist
perf evlist: Propagate thread maps through the evlist
perf tools: Make perf_evsel__(nr_)cpus generic
Markus Elfring (1):
perf header: Delete an unnecessary check before the calling free_event_desc()
tools/perf/builtin-stat.c | 10 ---------
tools/perf/tests/code-reading.c | 4 ++--
tools/perf/tests/keep-tracking.c | 4 ++--
tools/perf/tests/mmap-basic.c | 4 ++--
tools/perf/tests/mmap-thread-lookup.c | 2 +-
tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
tools/perf/tests/openat-syscall.c | 2 +-
tools/perf/tests/switch-tracking.c | 4 ++--
tools/perf/util/cpumap.c | 26 ++++++++++++++++++++--
tools/perf/util/cpumap.h | 6 ++++-
tools/perf/util/evlist.c | 35 +++++++++++++++++++++++++-----
tools/perf/util/evsel.c | 2 ++
tools/perf/util/evsel.h | 12 ++++++++++
tools/perf/util/header.c | 3 +--
tools/perf/util/parse-events.c | 5 ++++-
tools/perf/util/python.c | 4 ++--
tools/perf/util/record.c | 4 ++--
tools/perf/util/session.c | 2 +-
tools/perf/util/svghelper.c | 2 +-
tools/perf/util/thread_map.c | 32 ++++++++++++++++++++++++---
tools/perf/util/thread_map.h | 7 ++++--
21 files changed, 129 insertions(+), 43 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/7] perf header: Delete an unnecessary check before the calling free_event_desc()
2015-06-25 21:10 [GIT PULL 0/7] perf/core improvements Arnaldo Carvalho de Melo
@ 2015-06-25 21:10 ` Arnaldo Carvalho de Melo
2015-06-26 8:39 ` [GIT PULL 0/7] perf/core improvements Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-06-25 21:10 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Markus Elfring, Julia Lawall, Peter Zijlstra,
kernel-janitors, Arnaldo Carvalho de Melo
From: Markus Elfring <elfring@users.sourceforge.net>
The free_event_desc() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/558C2ABA.3000603@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 21a77e7a171e..03ace57a800c 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1063,8 +1063,7 @@ out:
free(buf);
return events;
error:
- if (events)
- free_event_desc(events);
+ free_event_desc(events);
events = NULL;
goto out;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [GIT PULL 0/7] perf/core improvements
2015-06-25 21:10 [GIT PULL 0/7] perf/core improvements Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 2/7] perf header: Delete an unnecessary check before the calling free_event_desc() Arnaldo Carvalho de Melo
@ 2015-06-26 8:39 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2015-06-26 8:39 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, David Ahern, Jiri Olsa,
Julia Lawall, kernel-janitors, Markus Elfring, Namhyung Kim,
Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
>
> The following changes since commit 27451700dfa01a05cdb4d9d74501536165158034:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-06-25 09:28:42 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to a22e99cd74a31dee4b5241bd60a256c629c808da:
>
> perf tools: Make perf_evsel__(nr_)cpus generic (2015-06-25 17:15:39 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and refactorings:
>
> Infrastructure:
>
> - Reference count the cpu_map and thread_map classes. (Jiri Olsa)
>
> - Set evsel->{cpus,threads} from the evlist, if not set,
> allowing the generalization of some 'perf stat' functions that
> previously were accessing private static evlist variable. (Jiri Olsa)
>
> - Delete an unnecessary check before the calling
> free_event_desc() (Markus Elfring)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf tools: Future-proof thread_map allocation size calculation
>
> Jiri Olsa (5):
> perf tools: Add reference counting for cpu_map object
> perf tools: Add reference counting for thread_map object
> perf evlist: Propagate cpu maps to evsels in an evlist
> perf evlist: Propagate thread maps through the evlist
> perf tools: Make perf_evsel__(nr_)cpus generic
>
> Markus Elfring (1):
> perf header: Delete an unnecessary check before the calling free_event_desc()
>
> tools/perf/builtin-stat.c | 10 ---------
> tools/perf/tests/code-reading.c | 4 ++--
> tools/perf/tests/keep-tracking.c | 4 ++--
> tools/perf/tests/mmap-basic.c | 4 ++--
> tools/perf/tests/mmap-thread-lookup.c | 2 +-
> tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
> tools/perf/tests/openat-syscall.c | 2 +-
> tools/perf/tests/switch-tracking.c | 4 ++--
> tools/perf/util/cpumap.c | 26 ++++++++++++++++++++--
> tools/perf/util/cpumap.h | 6 ++++-
> tools/perf/util/evlist.c | 35 +++++++++++++++++++++++++-----
> tools/perf/util/evsel.c | 2 ++
> tools/perf/util/evsel.h | 12 ++++++++++
> tools/perf/util/header.c | 3 +--
> tools/perf/util/parse-events.c | 5 ++++-
> tools/perf/util/python.c | 4 ++--
> tools/perf/util/record.c | 4 ++--
> tools/perf/util/session.c | 2 +-
> tools/perf/util/svghelper.c | 2 +-
> tools/perf/util/thread_map.c | 32 ++++++++++++++++++++++++---
> tools/perf/util/thread_map.h | 7 ++++--
> 21 files changed, 129 insertions(+), 43 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-26 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-25 21:10 [GIT PULL 0/7] perf/core improvements Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 2/7] perf header: Delete an unnecessary check before the calling free_event_desc() Arnaldo Carvalho de Melo
2015-06-26 8:39 ` [GIT PULL 0/7] perf/core improvements Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).