[patch] qla4xxx: remove some bogus casts

[patch] qla4xxx: remove some bogus casts

[Dan Carpenter]

These casts are wrong and unnecessary.  They annoy static checkers
because they imply we are planning to write sizeof(long) bytes to a
sizeof(u32) buffer which would corrupt memory.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index 4180d6d..d97ea5d 100644
--- a/drivers/scsi/qla4xxx/ql4_init.c
+++ b/drivers/scsi/qla4xxx/ql4_init.c
@@ -101,19 +101,13 @@ int qla4xxx_init_rings(struct scsi_qla_host *ha)
 	ha->response_ptr = &ha->response_ring[ha->response_out];
 
 	if (is_qla8022(ha)) {
-		writel(0,
-		    (unsigned long  __iomem *)&ha->qla4_82xx_reg->req_q_out);
-		writel(0,
-		    (unsigned long  __iomem *)&ha->qla4_82xx_reg->rsp_q_in);
-		writel(0,
-		    (unsigned long  __iomem *)&ha->qla4_82xx_reg->rsp_q_out);
+		writel(0, &ha->qla4_82xx_reg->req_q_out);
+		writel(0, &ha->qla4_82xx_reg->rsp_q_in);
+		writel(0, &ha->qla4_82xx_reg->rsp_q_out);
 	} else if (is_qla8032(ha) || is_qla8042(ha)) {
-		writel(0,
-		       (unsigned long __iomem *)&ha->qla4_83xx_reg->req_q_in);
-		writel(0,
-		       (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_in);
-		writel(0,
-		       (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_out);
+		writel(0, &ha->qla4_83xx_reg->req_q_in);
+		writel(0, &ha->qla4_83xx_reg->rsp_q_in);
+		writel(0, &ha->qla4_83xx_reg->rsp_q_out);
 	} else {
 		/*
 		 * Initialize DMA Shadow registers.  The firmware is really

Re: [patch] qla4xxx: remove some bogus casts

[Bart Van Assche]

On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> These casts are wrong and unnecessary.  They annoy static checkers
> because they imply we are planning to write sizeof(long) bytes to a
> sizeof(u32) buffer which would corrupt memory.

Hello Dan,

Can you verify whether that patch is still needed after having applied 
the patch series I posted in July (and that was acknowledged by QLogic): 
http://thread.gmane.org/gmane.linux.scsi/103135 ?

Thanks,

Bart.

Re: [patch] qla4xxx: remove some bogus casts

[Dan Carpenter]

On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> >These casts are wrong and unnecessary.  They annoy static checkers
> >because they imply we are planning to write sizeof(long) bytes to a
> >sizeof(u32) buffer which would corrupt memory.
> 
> Hello Dan,
> 
> Can you verify whether that patch is still needed after having
> applied the patch series I posted in July (and that was acknowledged
> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
> 

I think it is needed still?

regards,
dan carpenter

Re: [patch] qla4xxx: remove some bogus casts

[Bart Van Assche]

On 08/18/15 01:47, Dan Carpenter wrote:
> On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
>> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
>>> These casts are wrong and unnecessary.  They annoy static checkers
>>> because they imply we are planning to write sizeof(long) bytes to a
>>> sizeof(u32) buffer which would corrupt memory.
>>
>> Hello Dan,
>>
>> Can you verify whether that patch is still needed after having
>> applied the patch series I posted in July (and that was acknowledged
>> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
>>
>
> I think it is needed still?

Hello Dan,

You are right, this patch is indeed needed. Hence:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>