* [patch] scsi: aic94xx: set an error code on failure
@ 2015-08-18 9:20 Dan Carpenter
2015-08-18 9:58 ` Johannes Thumshirn
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-08-18 9:20 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Christoph Hellwig, Hannes Reinecke, Mike Christie, Dan Williams,
Venkatesh Srinivas, linux-scsi, kernel-janitors
We recently did some cleanup here and now the static checkers notice
that there is a missing error code when ioremap() fails. Let's set it
to -ENOMEM.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
index 140cb8e..f6c336b 100644
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -104,6 +104,7 @@ static int asd_map_memio(struct asd_ha_struct *asd_ha)
if (!io_handle->addr) {
asd_printk("couldn't map MBAR%d of %s\n", i=0?0:1,
pci_name(asd_ha->pcidev));
+ err = -ENOMEM;
goto Err_unreq;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] scsi: aic94xx: set an error code on failure
2015-08-18 9:20 [patch] scsi: aic94xx: set an error code on failure Dan Carpenter
@ 2015-08-18 9:58 ` Johannes Thumshirn
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Thumshirn @ 2015-08-18 9:58 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Christoph Hellwig, Hannes Reinecke,
Mike Christie, Dan Williams, Venkatesh Srinivas, linux-scsi,
kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> We recently did some cleanup here and now the static checkers notice
> that there is a missing error code when ioremap() fails. Let's set it
> to -ENOMEM.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
> index 140cb8e..f6c336b 100644
> --- a/drivers/scsi/aic94xx/aic94xx_init.c
> +++ b/drivers/scsi/aic94xx/aic94xx_init.c
> @@ -104,6 +104,7 @@ static int asd_map_memio(struct asd_ha_struct *asd_ha)
> if (!io_handle->addr) {
> asd_printk("couldn't map MBAR%d of %s\n", i=0?0:1,
> pci_name(asd_ha->pcidev));
> + err = -ENOMEM;
> goto Err_unreq;
> }
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-18 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-18 9:20 [patch] scsi: aic94xx: set an error code on failure Dan Carpenter
2015-08-18 9:58 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).