Re: [patch] ALSA: hdsp: silence a sprinft() overflow warning

Takashi Iwai
2015-08-22T09:37:02Z

On Sat, 22 Aug 2015 11:24:13 +0200,
Dan Carpenter wrote:
>
> card->shortname is a 32 char string so the sprintf() can theoretically
> overflow. snd_rawmidi_new() can accept strings up to 64 bytes long.
>
> I have made the temporay buf[] array 40 bytes long and changed the
> sprintf() to snprintf().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.

Takashi

>
> diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
> index 468a95c..afb2dea 100644
> --- a/sound/pci/rme9652/hdsp.c
> +++ b/sound/pci/rme9652/hdsp.c
> @@ -1526,7 +1526,7 @@ static struct snd_rawmidi_ops snd_hdsp_midi_input >
> static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int id)
> {
> - char buf[32];
> + char buf[40];
>
> hdsp->midi[id].id = id;
> hdsp->midi[id].rmidi = NULL;
> @@ -1537,7 +1537,7 @@ static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int i
> hdsp->midi[id].pending = 0;
> spin_lock_init (&hdsp->midi[id].lock);
>
> - sprintf (buf, "%s MIDI %d", card->shortname, id+1);
> + snprintf(buf, sizeof(buf), "%s MIDI %d", card->shortname, id + 1);
> if (snd_rawmidi_new (card, buf, id, 1, 1, &hdsp->midi[id].rmidi) < 0)
> return -1;
>
>