From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: dma-mapping: consolidate dma_{alloc,free}_{attrs,coherent}
Date: Sat, 12 Sep 2015 19:50:30 +0000 [thread overview]
Message-ID: <20150912195030.GB10112@mwanda> (raw)
Hello Christoph Hellwig,
This is a semi-automatic email about new static checker warnings.
The patch 60ff3365096f: "dma-mapping: consolidate
dma_{alloc,free}_{attrs,coherent}" from Aug 25, 2015, leads to the
following Smatch complaint:
arch/x86/kernel/pci-dma.c:137 arch_dma_alloc_attrs()
warn: variable dereferenced before check '*dev' (see line 134)
arch/x86/kernel/pci-dma.c
133 {
134 *gfp = dma_alloc_coherent_gfp_flags(*dev, *gfp);
^^^^
Dereferenced inside function call.
135 *gfp &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32);
136
137 if (!*dev)
^^^^^
Too late.
138 *dev = &x86_dma_fallback_dev;
139 if (!is_device_dma_capable(*dev))
regards,
dan carpenter
reply other threads:[~2015-09-12 19:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912195030.GB10112@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox