From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 12 Sep 2015 19:59:13 +0000
Subject: re: dsa: mv88e6xxx: Allow speed/duplex of port to be configured
Message-Id: <20150912195913.GA11157@mwanda>
List-Id: <kernel-janitors.vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

Hello Andrew Lunn,

The patch dea870242a9c: "dsa: mv88e6xxx: Allow speed/duplex of port
to be configured" from Aug 31, 2015, leads to the following static
checker warning:

	drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link()
	warn: unsigned 'ret' is never less than zero.

drivers/net/dsa/mv88e6xxx.c
   573  void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
   574                             struct phy_device *phydev)
   575  {
   576          struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
   577          u32 ret, reg;
   578  
   579          if (!phy_is_pseudo_fixed_link(phydev))
   580                  return;
   581  
   582          mutex_lock(&ps->smi_mutex);
   583  
   584          ret = _mv88e6xxx_reg_read(ds, REG_PORT(port), PORT_PCS_CTRL);
   585          if (ret < 0)

Probably make ret an int.

   586                  goto out;
   587  

regards,
dan carpenter