* re: dsa: mv88e6xxx: Allow speed/duplex of port to be configured
@ 2015-09-12 19:59 Dan Carpenter
2015-09-22 1:35 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-09-12 19:59 UTC (permalink / raw)
To: kernel-janitors
Hello Andrew Lunn,
The patch dea870242a9c: "dsa: mv88e6xxx: Allow speed/duplex of port
to be configured" from Aug 31, 2015, leads to the following static
checker warning:
drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link()
warn: unsigned 'ret' is never less than zero.
drivers/net/dsa/mv88e6xxx.c
573 void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
574 struct phy_device *phydev)
575 {
576 struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
577 u32 ret, reg;
578
579 if (!phy_is_pseudo_fixed_link(phydev))
580 return;
581
582 mutex_lock(&ps->smi_mutex);
583
584 ret = _mv88e6xxx_reg_read(ds, REG_PORT(port), PORT_PCS_CTRL);
585 if (ret < 0)
Probably make ret an int.
586 goto out;
587
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: dsa: mv88e6xxx: Allow speed/duplex of port to be configured
2015-09-12 19:59 dsa: mv88e6xxx: Allow speed/duplex of port to be configured Dan Carpenter
@ 2015-09-22 1:35 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2015-09-22 1:35 UTC (permalink / raw)
To: kernel-janitors
On Sat, Sep 12, 2015 at 10:59:13PM +0300, Dan Carpenter wrote:
> Hello Andrew Lunn,
>
> The patch dea870242a9c: "dsa: mv88e6xxx: Allow speed/duplex of port
> to be configured" from Aug 31, 2015, leads to the following static
> checker warning:
>
> drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link()
> warn: unsigned 'ret' is never less than zero.
>
> drivers/net/dsa/mv88e6xxx.c
> 573 void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
> 574 struct phy_device *phydev)
> 575 {
> 576 struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
> 577 u32 ret, reg;
> 578
> 579 if (!phy_is_pseudo_fixed_link(phydev))
> 580 return;
> 581
> 582 mutex_lock(&ps->smi_mutex);
> 583
> 584 ret = _mv88e6xxx_reg_read(ds, REG_PORT(port), PORT_PCS_CTRL);
> 585 if (ret < 0)
>
> Probably make ret an int.
Hi Dan
Thanks for the report. I agree, it should be an int. I will cook up a
patch.
Thanks
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-22 1:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-12 19:59 dsa: mv88e6xxx: Allow speed/duplex of port to be configured Dan Carpenter
2015-09-22 1:35 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).