* [patch] staging: wilc1000: off by one in get_handler_from_id()
@ 2015-09-15 6:54 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-09-15 6:54 UTC (permalink / raw)
To: kernel-janitors
The > should be >= here or we read beyond the end of the array.
Fixes: d42ab0838d04 ('staging: wilc1000: use id value as argument')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 59a1a9d..621fd18 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -637,7 +637,7 @@ static int get_id_from_handler(tstrWILC_WFIDrv *handler)
static tstrWILC_WFIDrv *get_handler_from_id(int id)
{
- if (id <= 0 || id > ARRAY_SIZE(wfidrv_list))
+ if (id <= 0 || id >= ARRAY_SIZE(wfidrv_list))
return NULL;
return wfidrv_list[id];
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-15 6:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-15 6:54 [patch] staging: wilc1000: off by one in get_handler_from_id() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).