From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 16 Sep 2015 06:41:50 +0000 Subject: Re: [patch] IB/hfi1: info leak in get_ctxt_info() Message-Id: <20150916064150.GH5004@mwanda> List-Id: References: <20150916062142.GB21542@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Mike Marciniszyn , Doug Ledford , Sean Hefty , Hal Rosenstock , Greg Kroah-Hartman , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, Sep 16, 2015 at 08:25:00AM +0200, Julia Lawall wrote: > On Wed, 16 Sep 2015, Dan Carpenter wrote: > > > The cinfo struct has a hole after the last struct member so we need to > > zero it out. Otherwise we don't disclose some uninitialized stack data. > > I think the "don't" wasn't intended in the second sentence? > Derp... I will resend. regards, dan carpenter