From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: iomap: implement pcim_iounmap_regions()
Date: Wed, 16 Sep 2015 18:14:15 +0000 [thread overview]
Message-ID: <20150916181415.GK5004@mwanda> (raw)
In-Reply-To: <20150916160024.GB9735@mwanda>
On Wed, Sep 16, 2015 at 01:10:00PM -0400, Tejun Heo wrote:
> Hello,
>
> On Wed, Sep 16, 2015 at 07:00:24PM +0300, Dan Carpenter wrote:
> > 421 for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
> > 422 if (!(mask & (1 << i)))
> > 423 continue;
> >
> > Probably maks is always valid is what helps us but basically the static
> > checker is suggesting that instead of DEVICE_COUNT_RESOURCE we should
> > be using PCI_ROM_RESOURCE or PCIM_IOMAP_MAX. It could be that this was
> > deliberate though...
>
> Looks like a silly mistake on my part. Care to submit a patch?
>
Sure, I will do that.
regards,
dan carpenter
prev parent reply other threads:[~2015-09-16 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 16:00 iomap: implement pcim_iounmap_regions() Dan Carpenter
2015-09-16 17:10 ` Tejun Heo
2015-09-21 16:21 ` [patch] devres: fix a for loop bounds check Dan Carpenter
2015-09-21 17:40 ` Tejun Heo
2015-09-16 18:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916181415.GK5004@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox