From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Date: Tue, 13 Oct 2015 12:27:11 +0000 Subject: Re: [patch] ASoC: wm8904: harmless underflow in wm8904_put_deemph() Message-Id: <20151013122711.GF8805@ck-lbox> List-Id: References: <20151013070818.GB31537@mwanda> In-Reply-To: <20151013070818.GB31537@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Fabio Estevam , Krzysztof Kozlowski , Lars-Peter Clausen , alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Alexander Morozov , Mark Brown , Bo Shen On Tue, Oct 13, 2015 at 10:08:18AM +0300, Dan Carpenter wrote: > We try to check that "deemph" is zero or one, but because of an > underflow bug, it can also be negative. It's fine, negative values are > handled as non-zero. But it's messy and static checkers complain so > let's fix it. > > Signed-off-by: Dan Carpenter Acked-by: Charles Keepax Thanks, Charles